[alert,dv] Fix timing for ping timeouts in alert handler test#29332
Merged
rswarbrick merged 1 commit intolowRISC:masterfrom Feb 18, 2026
Merged
[alert,dv] Fix timing for ping timeouts in alert handler test#29332rswarbrick merged 1 commit intolowRISC:masterfrom
rswarbrick merged 1 commit intolowRISC:masterfrom
Conversation
This was broken (I think) by the change in c254e65, which changed the monitor to see the ping signal change through a clocking block. Alert handler tests work by modelling the ping timeout in the alert monitor (??!!!) and this ended up a cycle late. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
rswarbrick
added
Component:DV
vogelpi
approved these changes
Feb 17, 2026
Contributor
vogelpi
left a comment
vogelpi
left a comment
There was a problem hiding this comment.
Thanks @rswarbrick , this is a big improvement already. I increases the pass rate of the alert_handler_ping_timeout test from 0% to 50% (at least when I tested it). The remaining failures I see are:
- Either because the crashdump checking is still slighlty too early (increasing the
wait_n_clks(2)to 3 on Line 571 can help, this is because this function checks the mirrored loc_alert_cause register, the prediction is updated based on the alert event sent to the scoreboard by the monitor, seeprocess_alert_sig()task), - or because the
intr_stateregister doesn't match the predicted value, it's also updated by theprocess_alert_sig()task .
So I think this solution is not perfect but it's a great step in the right direction and we can maybe do a follow up at some point to fix this for good?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was broken (I think) by the change in c254e65, which changed the monitor to see the ping signal change through a clocking block. Alert handler tests work by modelling the ping timeout in the alert monitor (??!!!) and this ended up a cycle late.