chore(deps): upgrade to Spring Boot 4.0.6 in application-server, notification, and helios-status-spring-starter#1021
chore(deps): upgrade to Spring Boot 4.0.6 in application-server, notification, and helios-status-spring-starter#1021
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | ✅ 0 (≤ 20 complexity) |
🟢 Coverage ∅ diff coverage · +0.37% coverage variation
Metric Results Coverage variation ✅ +0.37% coverage variation (-1.00%) Diff coverage ✅ ∅ diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (f232003) 9628 4369 45.38% Head commit (cf1def7) 9628 (+0) 4405 (+36) 45.75% (+0.37%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#1021) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
176b319 to
ab38793
Compare
…fication, and helios-status-spring-starter
ab38793 to
928eb95
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf1def7a6f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| implementation 'io.sentry:sentry-spring-boot-starter-jakarta:8.40.0' | ||
| implementation 'io.sentry:sentry-spring-boot-4-starter:8.40.0' | ||
| // Helios push-based status updates | ||
| implementation "de.tum.cit.aet:helios-status-spring-starter:1.1.0" |
There was a problem hiding this comment.
Update app to consume the Boot 4 starter release
After bumping helios-status-spring-starter to 1.1.1 (Boot 4 aligned), application-server still depends on 1.1.0, so this service does not actually use the upgraded starter and can keep pulling an artifact built against the old Boot 3 baseline. In this upgrade commit, that mismatch undermines the migration and risks runtime incompatibilities when starter classes are loaded under Boot 4; the dependency here should be moved to 1.1.1 to keep the module graph consistent.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
For now, I couldn't release a new helios-status-spring-starter version to Maven Central and because I’m blocked by Sonatype: Namespace 'de.tum.cit.aet' is not allowed. I also verified that existing workflow (release-maven.yaml) doesn't work and its secret values don't exist in GitHub secrets. So, let's keep it as it is and upgrade it after maven release is complete.
Motivation
This upgrade keeps Helios on the supported Spring Boot 4 baseline, improves long-term maintainability. #994
Description
This PR upgrades Spring Boot to
4.0.6across the three backend modules and adjusts dependencies/imports/tests for Boot 4 compatibility.4.0.6(server/build.gradle).helios-status-spring-starterBOM to4.0.6, version1.1.1).3.0.3.spring.http.converters.preferred-json-mapper: jackson2.Testing Instructions
Prerequisites:
Flow:
cd server./gradlew :application-server:clean./gradlew :application-server:test./gradlew :notification:bootRunDev --args='--nats.enabled=false --server.port=18082'application-servertests pass.notificationstarts successfully on port18082with NATS disabled.Checklist
General
Server