feat: use configured deploy job for deployment time estimates#939
feat: use configured deploy job for deployment time estimates#939mertilginoglu merged 6 commits intostagingfrom
Conversation
3395ab1 to
3f5aa10
Compare
Not up to standards ⛔🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity |
🟢 Coverage 53.42% diff coverage · +0.26% coverage variation
Metric Results Coverage variation ✅ +0.26% coverage variation (-1.00%) Diff coverage ✅ 53.42% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (278a4fc) 10087 4191 41.55% Head commit (90144fc) 10244 (+157) 4283 (+92) 41.81% (+0.26%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#939) 161 86 53.42% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
TIP This summary will be updated as you push new changes. Give us feedback
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a0573ddc2a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
meryemefe
left a comment
There was a problem hiding this comment.
I tested locally. It works very well. I have only some minor comments. Also, I would like to remind that you need to update the version of flyway while merging conflicts.
|
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
2bfd90f to
6e04ab7
Compare
…sitory ID and streamline upsert logic
Motivation
Helios currently uses fixed timing assumptions when estimating how long a deployment will stay in pending and in-progress states. That makes the deployment progress view inaccurate for workflows whose actual deploy step starts much later or earlier than the default assumption. This change lets repositories configure the GitHub Actions job that represents the real deployment start so Helios can calculate more accurate build and deploy duration estimates.
Description
deployJobNameper workflowTesting Instructions
Prerequisites:
Flow:
SettingsConfigurein the newDeployment Jobcolumn for a deployment workflowChecklist
General
Server