@lute/fs: clean up some smaller problems in the filesystem implementation code#1073
Merged
Conversation
vrn-sn
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a bunch of small fixes/clean up work for various things across the implementation of
@lute/fs, including:initializeFSwhere it was mistakenlyinitalizeFSsetFlagsto have clearer names without shadowingcreateDurationFromTimespec32to just be an overload ofcreateDurationFromTimespecwithout suggesting any particular bit sizingstd::fillzero-pass over the read chunk buffer inFSRead::readCallbacksince onlybytesReadbytes are ever appended to the output buffer, meaning nothing ever actually looks at the zeroed bytes.a) mode to includeO_CREATto make it consistent with general POSIX behavior where append will create non-existent files.The biggest/most disruptive change here is a change to how we validate arguments to functions. Looking at the Luau VM code and the existing built-in libraries for Luau, it's actually very abnormal to do
lua_gettopand produce errors for argument counts and so forth. The general pattern is that functions will do typechecks for the arguments they're expecting, and silently ignore any additional arguments. I've changed the filesystem library to be consistent with this behavior in this PR, and I'll put up a follow-up PR to make this change across the whole project.