Split tests and snapshots into separate steps#1089
Merged
Conversation
aatxe
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since windows uses powershell by default, the
lute testexit code is ignored and the snapshot one is just used. So if tests fail but snapshots pass, the CI step still passes on windows. By splitting the tests into two separate steps we should fix this. Alternatively we could force the shell to bash, but I think splitting into two steps is fine.See an example of failing tests but still passing the step: https://github.com/luau-lang/lute/actions/runs/25634139014/job/75242932282?pr=1081