Closed
Conversation
…fancy thing instead of table.clear
aatxe
requested changes
Apr 12, 2025
aatxe
requested changes
May 1, 2025
Member
aatxe
left a comment
aatxe
left a comment
There was a problem hiding this comment.
I don't want us to ignore the code formatter just because "it's better." The whole point of the code formatter is that we don't have to have discussions about what is or isn't better.
Member
|
I think this got superseded by the other PR for ansi, but feel free to reopen if some of this optimization is still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaceClosewith table.concat, as table.concat is faster than repeatedly doingstr ..= "meow"