Avoid duplicate tags when updating files #232
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we cannot know in every case whether the tags file contains absolute or relative pathnames, let's remove old tags that use either version of the pathname. Fixes ludovicchabant#231 for Unix. Unfortunately my Windows scripting skills are insufficient to update plat/win32/update_tags.cmd
|
I have tested this and I can stamp it 🥇 Works On My Machine Certified 🥇 . |
|
Thanks, it's an annoying issue still unsolved, so I'm going to use your branch. |
|
was this merged some other way ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we cannot know in every case whether the tags file contains absolute or relative pathnames, let's remove old tags that use either version of the pathname.
Fixes #231 for Unix. Unfortunately my Windows scripting skills are insufficient to implement the full logic in plat/win32/update_tags.cmd, but at least I updated the argument parsing loop so it won't fail if it sees the new -a argument.