Skip to content

Conversation

xmasscan
Copy link
Contributor

Updated scripts/sitemap.sh to extract the title from every HTML file for display on the sitemap, rather than its filename & absolute path.

Additionally:

  • Removed CNAME (already done in main, just syncing dev with main)
  • Added minor comments in the Makefile & removed need to mirror static between two folders (no editing required & users can still contribute in the same way)
  • Gave Kevin's Opsec article a title and gave the Vimlab article a more descriptive title
  • Changed index page's tab title to read "Linux User Group" rather than "Linux User's Group"

@xmasscan xmasscan requested review from lowpolyneko and SohamG August 22, 2025 02:28
@xmasscan
Copy link
Contributor Author

I made a huge mistake before; Make demo treats the public folder as the webserver's root folder. I assume the website does the same. If this is the case, then my previous commits would have moved static to a place it would not be able to reach in the file directory and caused all links to break.

static is now a subdirectory of public (public/static). I modified the Makefile's clean recipe to ignore it and its sub-directories. From my testing, it should run as it did before while preserving the integrity of static. I also modified the .gitignore so now it tracks public, but not the html pages stored inside of it. The only content within public that is tracked is the aforementioned static folder and its subdirectories and files.

@SohamG
Copy link
Contributor

SohamG commented Aug 22, 2025

Its always a better strat to have "public" be solely "generated" stuff, that is recreate-able and can be purged. I would recommend having static outside of public in the source tree. This way stuff isnt accidentally committed or forgotten, and getting a clean build is easy as nuking one folder.

However if this is what is desired I have no issue per se.

@xmasscan
Copy link
Contributor Author

To be honest, after taking a walk and thinking it over, I liked that I figured out how to do that, but I ultimately have to agree. Everything I added feels sidestep-y in a way I was trying to avoid by doing this... I do like the sitemap update though, so I will just revert the static management changes.

@xmasscan
Copy link
Contributor Author

Also, thank you for responding to my comment; Reading it back with that context makes it make much more sense. I totally agree that introducing inaccurate comments is worse than none at all.

@xmasscan
Copy link
Contributor Author

This took way too long for me to figure out because I didn't realize I needed to do git push --force rather than git push, lol. Now I actually understand rebasing though, so I'm far from disappointed! Squashing commits here makes everything look more readable and understandable. If you'd like me to rename the commits, please let me know, but I think this should work!

@lowpolyneko
Copy link
Member

LGTM at this point. Thank you for all your hard work!

@lowpolyneko lowpolyneko merged commit b44f452 into main Aug 24, 2025
@lowpolyneko lowpolyneko deleted the dev branch August 24, 2025 04:07
@lowpolyneko lowpolyneko restored the dev branch August 24, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants