-
Notifications
You must be signed in to change notification settings - Fork 7
Dev Merge - sitemap update & minor clerical changes #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I made a huge mistake before; Make demo treats the public folder as the webserver's root folder. I assume the website does the same. If this is the case, then my previous commits would have moved static to a place it would not be able to reach in the file directory and caused all links to break.
|
Its always a better strat to have "public" be solely "generated" stuff, that is recreate-able and can be purged. I would recommend having static outside of public in the source tree. This way stuff isnt accidentally committed or forgotten, and getting a clean build is easy as nuking one folder. However if this is what is desired I have no issue per se. |
To be honest, after taking a walk and thinking it over, I liked that I figured out how to do that, but I ultimately have to agree. Everything I added feels sidestep-y in a way I was trying to avoid by doing this... I do like the sitemap update though, so I will just revert the |
Also, thank you for responding to my comment; Reading it back with that context makes it make much more sense. I totally agree that introducing inaccurate comments is worse than none at all. |
This took way too long for me to figure out because I didn't realize I needed to do |
LGTM at this point. Thank you for all your hard work! |
Updated
scripts/sitemap.sh
to extract the title from every HTML file for display on the sitemap, rather than its filename & absolute path.Additionally: