Merge pull request #54 from luislavena/fix/fluke-windows-test

Fix fluke errors in Windows
luislavena · Apr 5, 2020 · c640b05 · c640b05
2 parents 6668adc + e4bbe02
commit c640b05
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 0 deletions.
diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml
@@ -40,5 +40,7 @@ jobs:
     - name: Run test
       run: |
         rake test
+    - name: Run packaging
+      run: |
         rake package
         gem install --local pkg/gem-compiler-*.gem
diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml
@@ -40,5 +40,7 @@ jobs:
     - name: Run test
       run: |
         rake test
+    - name: Run packaging
+      run: |
         rake package
         gem install --local pkg/gem-compiler-*.gem
diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
@@ -33,5 +33,7 @@ jobs:
     - name: Run test
       run: |
         rake test
+    - name: Run packaging
+      run: |
         rake package
         gem install --local pkg/gem-compiler-*.gem
diff --git a/test/rubygems/test_gem_compiler.rb b/test/rubygems/test_gem_compiler.rb
@@ -404,6 +404,9 @@ def test_compile_strip_cmd
     util_reset_arch
     hook_simple_run
 
+    old_rbconfig_strip = RbConfig::CONFIG["STRIP"]
+    RbConfig::CONFIG["STRIP"] = "rbconfig-strip-cmd"
+
     gem_file = util_bake_gem("foo") do |spec|
       util_dummy_extension spec, "bar"
     end
@@ -423,6 +426,7 @@ def test_compile_strip_cmd
     refute_match %r|#{RbConfig::CONFIG["STRIP"]}|, @ui.output
     assert_match %r|using 'echo strip-custom'|, @ui.output
   ensure
+    RbConfig::CONFIG["STRIP"] = old_rbconfig_strip
     restore_simple_run
   end