-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sass support #22
base: step2
Are you sure you want to change the base?
sass support #22
Conversation
andreasonny83
commented
Jan 24, 2016
- demo project inside the repo
- distribution folder with the minimized version of the library for start using css-loaders in other projects
- documentation updated
- removed unused code
- package.json fixed
- other minor improvements
* demo project inside the repo * distribution folder with the minimized version of the library for start using css-loaders in other projects * documentation updated * removed unused code * package.json fixed * other minor improvements
@andreasonny83 thanks for making this request. |
Yes, that's right. The dist folder will be visible in the repository containing the latest stable build of the library. In this way, people can simply download the zipped version or cloning the repository and start using the cssloader in their projects without the need of installing all the node packages and compile a new version every time. |
It is quite common to have a dist folder from where people can start using the library without compiling the source code. Have a look at the Twitter Bootstrap repository for example: https://github.com/twbs/bootstrap |
* step2: sync
merging step2 from lukehaas/css-loader
* step2: let box-shadow inherit colour instead of defining it fix small error in fading dots animation
Hi @lukehaas, I merged your latest step2 branch inside this pull request to resolve some merge conflicts. The pull request is clean again and ready to be merged. Let me know if you're happy with this. |
Thanks @andreasonny83, you're right, it's a good idea to have the compiled css available. |