Update imagedata.h #1836
Open
Update imagedata.h #1836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leave 25 pixels, i.e. 12.5 top and bottom
added a 64x64 pixel version of the logo for OLED 128x64 and Nokia LCD displays. Reduced structure to 64x64 to conserve half of the PROGMEM space instead of 128x64 pixel size. May need to be displayed centered on display.
15 px top and 15 px bottom white border added for Knickohr
|
The 64x64 graphic is currently not implemented - am I right? |
|
wouldn't it be better to align the logo in ePaper centered as well and remove the 25px white border from the image data? Memory is costly, therefore I would prefer to store only necessary data. |
|
@lumapu yes, these are both valid points. |
As requested by @lumapu I have reduced both logo sizes. I have added the display size these logos fit and the required left/right and top/bottom padding in a comment each. You will have to replace all occurrences of logo with logo_spiral_140x150 or implement logo_spiral_52x56 for the OLED and Nokia LCD Displays.
|
@lumapu I have prepared two Versions for the different displays:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated the logo with a proper logarithmic spiral cable