Check for email.visibility also when looking for user email. (#437)

* Check for email.visibility also when looking for user email. * Update the error message when looking for public primary email. --------- Co-authored-by: Ushi Hiraga <[email protected]>
lumen-notes · Nov 27, 2024 · 233ce24 · 233ce24
1 parent f337973
commit 233ce24
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/netlify/edge-functions/github-auth.ts b/netlify/edge-functions/github-auth.ts
@@ -69,11 +69,11 @@ async function getUser(token: string) {
     throw new Error("Error getting user's emails")
   }
 
-  const emails = (await emailResponse.json()) as Array<{ email: string; primary: boolean }>
-  const primaryEmail = emails.find((email) => email.primary)
+  const emails = (await emailResponse.json()) as Array<{ email: string; primary: boolean; visibility: string }>
+  const primaryEmail = emails.find((email) => email.primary && email.visibility === "public")
 
   if (!primaryEmail) {
-    throw new Error("No primary email found")
+    throw new Error("No public primary email found. Check your privacy settings in https://github.com/settings/emails")
   }
 
   return { login, name, email: primaryEmail.email }