Skip to content

Update icon sizing #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2025
+4 −3
Merged

Update icon sizing #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/emoji-favicon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export function EmojiFavicon({ emoji }: { emoji: string }) {
return (
<svg className="size-icon overflow-visible" viewBox="0 0 16 16">
<text x="50%" y="50%" dominantBaseline="central" textAnchor="middle" className="text-sm">
<text x="50%" y="50%" dominantBaseline="central" textAnchor="middle" fontSize="16px">
{emoji}
</text>
</svg>
Expand Down
3 changes: 2 additions & 1 deletion src/components/github-avatar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ export function GitHubAvatar({ login, size = 32, className, ...props }: GitHubAv
aria-hidden
alt=""
src={`https://github.com/${login}.png?size=${size * 2}`}
className={cx("inline-block size-icon flex-shrink-0 !rounded-full bg-[white]", className)}
className={cx("inline-block flex-shrink-0 !rounded-full bg-[white]", className)}
style={{ width: size, height: size }}
{...props}
/>
)
Expand Down
2 changes: 1 addition & 1 deletion src/components/note-favicon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export const NoteFavicon = React.memo(

// GitHub
if (typeof note.frontmatter.github === "string" && online) {
icon = <GitHubAvatar data-testid="favicon-github" login={note.frontmatter.github} />
icon = <GitHubAvatar data-testid="favicon-github" login={note.frontmatter.github} size={16} />
}

// URL
Expand Down