Fix and improve error reporting when sbt start fails #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
startIfNotStartedfailed for any reason while on background thread (for example when building from run configuration), error report would fail (trace). This PR fixes this crash by handling UI explicitly on UI thread and improves UX by showing what was SBT started for.(Action info would not be that important, but since the plugin calls
startIfNotStartedSafethree times in succession, three identical error notifications were strange.)When SBT fails to start when starting the SBT console, the notification is visually the same (small popup from the bottom bar), but standard notification balloon is shown when the error is during pre-run.