Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add Windows support #58

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

AucaCoyan
Copy link

@AucaCoyan AucaCoyan commented Dec 27, 2024

Hi! I like this app so much that I'm pull requesting the windows support ❤️

It compiles in windows, and works on Debian 💯

@AucaCoyan AucaCoyan marked this pull request as ready for review December 27, 2024 23:31
@AucaCoyan
Copy link
Author

would you approve the workflow to see if I made a mistake somewhere? 🙏🏼

@AucaCoyan AucaCoyan marked this pull request as draft January 13, 2025 18:15
@AucaCoyan
Copy link
Author

AucaCoyan commented Jan 13, 2025

I merged master and solved the issue with lifetimes.
Sadly, ran the tests and had a failure in test merge_002

running 18 tests
test branch_003 ... ok
test branch_002 ... ok
test branch_001 ... ok
test branch_005 ... ok
test branch_004 ... ok
test merge_002 ... FAILED
test merge_003 ... ok
test merge_001 ... ok
test complex_001 ... ok
test orphan_001 ... ok
test merge_004 ... ok
test orphan_002 ... ok
test merge_005 ... ok
test stash_003 ... ok
test stash_001 ... ok
test stash_002 ... ok
test stash_004 ... ok
test straight_001 ... ok

failures:

---- merge_002 stdout ----
*   9280933 Merge branch '40'
|\
| * 2298534 041
| * f4022e8 032
| * 248648a 031
|/
| * cf3313d 022
| * 3be6c3d 021
|/
| * b053aba 012
| * 61077e9 011
|/
* b30f89c 001
thread 'merge_002' panicked at tests\graph.rs:1166:9:
Image dimensions are different. expected: (600, 500), actual: (550, 450)
Image dimensions are different. expected: (550, 500), actual: (550, 450)
stack backtrace:
   0: std::panicking::begin_panic_handler
             at /rustc/9fc6b43126469e3858e2fe86cafb4f0fd5068869\library/std\src\panicking.rs:665
   1: core::panicking::panic_fmt
             at /rustc/9fc6b43126469e3858e2fe86cafb4f0fd5068869\library/core\src\panicking.rs:76
   2: core::panicking::panic_display<alloc::string::String>
             at C:\Users\aucac\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\panicking.rs:269
   3: graph::assert_graph_images::panic_cold_display<alloc::string::String>
             at C:\Users\aucac\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\panic.rs:100
   4: graph::assert_graph_images
             at .\tests\graph.rs:1166
   5: graph::merge_002
             at .\tests\graph.rs:467
   6: graph::merge_002::closure$0
             at .\tests\graph.rs:424
   7: core::ops::function::FnOnce::call_once<graph::merge_002::closure_env$0,tuple$<> >
             at C:\Users\aucac\.rustup\toolchains\stable-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core\src\ops\function.rs:250
   8: core::ops::function::FnOnce::call_once
             at /rustc/9fc6b43126469e3858e2fe86cafb4f0fd5068869\library/core\src\ops\function.rs:250
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.


failures:
    merge_002

test result: FAILED. 17 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 42.28s

error: test failed, to rerun pass `--test graph`

It just fails on windows, I ran this branch on Debian and all the tests passed successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant