Annotate .gitmodules with branch and tag #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Tim! My 👍 just meant I approve of anything that makes the build process easier, but I don't know enough to properly sign off on this. |
|
No worries, thanks for the 👍🏽 |
creationix
requested review from
zhaozg and
squeek502
and removed request for
SinisterRectus
squeek502
approved these changes
Feb 21, 2024
|
This sounds interesting. Depending on how it goes we might eventually make use of this in Lit as well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on an experiment to make submodules easier to work with. Part of that is annotating .gitmodules with information to make it so tools can automatically update dependencies.
The
branchfield is actually supported already by upstream git itself.The
tagfield is my invention and my tool may be using it to do semver updates based on the tag name and available upstream tags.I'm not convinced the tag needs to be documented here since the commit hash is already in git and it possible to map that back to tags. I've removed
tagfrom the PR for now till I'm convinced it needs to be in the file.