Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass -fno-sanitize-recover=all to make all UBSan detections fatal #698

Merged
merged 3 commits into from
Mar 2, 2024

Conversation

squeek502
Copy link
Member

@squeek502 squeek502 commented Mar 1, 2024

From the clang docs:

By default, non-fatal checks are those enabled by UndefinedBehaviorSanitizer, except for -fsanitize=return and -fsanitize=unreachable.

Closes #697

From the clang docs:

> By default, non-fatal checks are those enabled by UndefinedBehaviorSanitizer, except for -fsanitize=return and -fsanitize=unreachable.
This was doing pointer addition where i could be >= LUV_THREAD_MAXNUM_ARG and then subtracting afterwards. By doing the subtraction first, the number is properly bounded within 0..LUV_THREAD_MAXNUM_ARG
@squeek502 squeek502 enabled auto-merge (rebase) March 1, 2024 22:23
@squeek502 squeek502 merged commit 549a093 into luvit:master Mar 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UBSan is detecting problems but not failing the CI
2 participants