Fix background HMR by @tyn1998

[octohedron]

As per this comment #40 (comment) I extracted the fix for the HMR, and did some minor updates

• Popup and Greetings are now tsx files
• Added a button to the Popup with a counter as an example
• Added an example for listening to tab changes in the background

chrome.tabs.onUpdated.addListener(function (tabId, changeInfo, tab) {
  if (changeInfo.status == 'complete') {
    console.log('Tab finished loading', tabId, tab);
    // do your things
  }
});

• Updated the webpack config and README

TODO: Add instructions as explained in #40 (comment)

[amehito]

expecting for merger

[headfire94]

Can you please explain why is this needed?

[octohedron]

The host_permissions are required if you want to inject something in a matching page, download from a matching URL, or observe via webRequest and similar APIs.

Most extensions will need it, not all of course, I spent a considerable amount of time trying to figure out why things were not working and that was one of the issues.

Could be added to the readme or removed, as you wish, personally, for a boilerplate, I would add all the possible fields in there with default values so new developers know what they can use or could be the cause of an issue.

[joshsmith]

It might make sense to have the fields you may want (as in my case, including host_permissions) commented out in the file, and in the uncommented code support the most basic and least permissive cases. It's an approach I've seen in other config files that would also work here, and also one that doesn't risk someone accidentally asking for permissions they don't need.

[moshOntong-IT]

it seems the package author is not active

[VecHK]

good job

[joshsmith]

It might be nice to link somewhere in the documentation that explains this reasoning.

[joshsmith]

@lxieyang I know things come up (I've been there an OSS maintainer in the past). If you're not able to remain active, would you mind considering opening up shared responsibility to contributors who appear interested in helping to maintain the repo?

[lancesnider]

Nitpick. This doesn't need to be a let. Setting it to const is fine, even though you're updating something within the object.