Skip to content
This repository was archived by the owner on Feb 2, 2026. It is now read-only.

Make Typescript work out of the box#52

Closed
kcirtaptrick wants to merge 2 commits intolxieyang:masterfrom
kcirtaptrick:ts
Closed

Make Typescript work out of the box#52
kcirtaptrick wants to merge 2 commits intolxieyang:masterfrom
kcirtaptrick:ts

Conversation

@kcirtaptrick
Copy link

@kcirtaptrick kcirtaptrick commented May 23, 2021

MERGE #51 FIRST

  • Adds @types/webpack-env package for module.hot types
  • Remove filename from entrypoints to make Webpack choose defaults. This will choose any index file instead of just .js/jsx
  • Add src/types.d.ts with asset and css module

Replaces node-sass with sass package to resolve GYP error
secrets.*.js

# editor configs
/.vscode

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of scope of task.

"react-dom": "^17.0.1",
"react-hot-loader": "^4.13.0"
"react-hot-loader": "^4.13.0",
"sass": "^1.34.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already exist a PR for add sass.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants