[INTPROD-9686] Add threaded conversation support

docs/root/adding_new_slack_apps.rst

@@ -50,6 +50,8 @@ Adding normal slack apps
       * Note 2: the configuration `bot.name` for your bot should match your app user_handle
       * Note 3: if your app user_handle does not match your `bot.name` you need to
         specify `match_mention: true` to receive callbacks
+      * Note 4: if you want your app to handle thread replies, you need to
+        specify `match_reply: true` to receive callbacks
 
 
 #. Add interactive component configuration (if the bot needs interactive components), using the ``Interactive Components`` link in the sidebar:

omnibot/processor.py

@@ -113,6 +113,9 @@ def _process_message_message_handlers(message: Message):
     command_matched = False
     handler_called = False
     for handler in bot.message_handlers:
+        # We only match replies if the handler is set to match them
+        if message.thread_ts and not handler.get("match_reply", False):
+            continue
         # We only match commands against directed messages
         if handler["match_type"] == "command":
             if not _should_handle_command(handler, message):

omnibot/services/slack/message.py

@@ -17,6 +17,7 @@ def __init__(self, bot: Bot, event: dict, event_trace: dict):
         super().__init__(bot, event, event_trace, "message")
         self._payload["ts"] = event["ts"]
         self._payload["thread_ts"] = event.get("thread_ts")
+        self._payload["parent_user_id"] = event.get("parent_user_id")
         self._check_unsupported()
         try:
             self._payload["text"] = event["text"]
@@ -50,10 +51,6 @@ def _check_unsupported(self):
         elif self.user and self.user == "USLACKBOT":
             logger.debug("ignoring message from slackbot", extra=self.event_trace)
             unsupported = True
-        # Ignore threads
-        elif self.thread_ts:
-            logger.debug("ignoring thread message", extra=self.event_trace)
-            unsupported = True
         # For now, ignore all event subtypes
         elif self.subtype:
             extra = {"subtype": self.subtype}
@@ -201,8 +198,19 @@ def mentioned(self):
 
     @property
     def thread_ts(self):
+        """
+        The timestamp of the parent message, if this is a reply to a message.
+        :return:
+        """
         return self._payload["thread_ts"]
 
+    @property
+    def parent_user_id(self):
+        """
+        The user_id of the parent message, if this is a reply to a message.
+        """
+        return self._payload["parent_user_id"]
+
     @property
     def channels(self):
         return self._payload.get("channels", {})

tests/unit/omnibot/services/slack/message_test.py

@@ -124,11 +124,6 @@ def test_message(mocker):
     with pytest.raises(MessageUnsupportedError):
         _message = Message(_bot, event_copy, event_trace)
 
-    event_copy = copy.deepcopy(event)
-    event_copy["thread_ts"] = "1234568.00"
-    with pytest.raises(MessageUnsupportedError):
-        _message = Message(_bot, event_copy, event_trace)
-
     event_copy = copy.deepcopy(event)
     event_copy["subtype"] = "some_subtype"
     with pytest.raises(MessageUnsupportedError):