Skip to content

fix: align testing spinner icon in start button#190

Merged
robertodauria merged 3 commits intom-lab:mainfrom
mdfarid01:fix-182-spinner-alignment
Mar 3, 2026
Merged

fix: align testing spinner icon in start button#190
robertodauria merged 3 commits intom-lab:mainfrom
mdfarid01:fix-182-spinner-alignment

Conversation

@mdfarid01
Copy link
Copy Markdown
Contributor

Fixes #182

What changed

  • Added a scoped CSS fix for the spinner icon in the "Testing" state (#startButton .btn-testing .fa-spin).
  • Set letter-spacing: 0, transform-origin: 50% 50%, and vertical-align: middle to keep rotation visually centered.

Why

  • The spinner appeared off-center/wobbly during the Testing state.
  • This keeps the fix local to the start-button spinner and avoids affecting other icons globally.

Testing

  • Ran npm run build -- staging
  • Verified locally that the spinner appears centered while rotating during Testing state

Copilot AI review requested due to automatic review settings March 1, 2026 19:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses UI polish in the speed test start button by scoping a CSS adjustment to the Font Awesome spinner shown during the “Testing” state, eliminating the off-center/wobbly rotation reported in #182.

Changes:

  • Added a targeted CSS rule for #startButton .btn-testing .fa-spin to improve the spinner’s perceived centering while rotating.
  • Adjusted letter-spacing, transform-origin, and vertical-align specifically for the “Testing” spinner to avoid global icon side effects.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@robertodauria robertodauria self-requested a review March 2, 2026 00:04
@bassosimone bassosimone changed the title fix: align testing spinner icon in start button (#182) fix: align testing spinner icon in start button Mar 2, 2026
@robertodauria robertodauria self-requested a review March 3, 2026 21:56
Copy link
Copy Markdown
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@robertodauria robertodauria merged commit 9284c82 into m-lab:main Mar 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Spinner icon rotates off-center during "Testing" state

3 participants