Lowering max message size in upload worker #365
Conversation
this should fix connection closed prematurely for upload test on chrome
|
@mkwiatkowskisoldevelo thank you for this change request. @robertodauria is currently on vacation through Aug 15th and has the most experience with performance tuning the server and js clients. He is the best to review your proposed changes. |
There was a problem hiding this comment.
As far as I know the minimal client included in this repository is only used for e2e testing via nodejs, while ndt7-js is the recommended reference client for integrators. In ndt7-js I changed the maximum message size to 8MB some time ago to work around a different bug (only happening on Safari). It makes sense to also change it here, especially if it's causing problems on other browsers, too.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained
We've discovered, that while using the embedded js client to run ndt7 tests, the upload speeds are very low for the connections at higher speeds (we were testing it with 4G and 10G). The reason is that the WebSocket connection is closed at the begging of the tests. The connection is closed by the server because its buffer is overflowing. This happens on the following browsers: Chrome, Edge, and Safari. Firefox is completing the upload test normally for the same set-up.
As a fix for this issue, we're proposing lowering the maxMessageSize on the upload worker on the JS client from 16MB to 8MB. This is also a value used in the other JS client: ndt7-js. This client could also replace the current one, if it's OK with you I could add it as a part of this PR. I see that there is a PR that introduces that client, but it is over 2 years old and there were some changes in the other repository recently.
Another way to stop the upload test from failing is to slightly increase MaxMessageSize on the server side, which is set to 16MB. Changing it to 18MB is enough for our testing.
It would help us greatly in using NDT if you could include this change or resolve this issue.
Thank you very much in advance.
This change is