Skip to content

Conversation

@rmi22186
Copy link
Member

Background

Our cookie sync builds a url by appending settings from the pixel configuration. It was discovered that The Trade Desk (TTD) requires a domain parameter when a user is subject to GDPR (ie. user accesses the internet from the UK).

The parameter is optional, but to keep things simple, we will be adding it to each time a TTD pixel needs to be fired.

What Has Changed

This PR adds updates to:

  • Cookie sync manager - added constants for each potential cookie sync partner we have (you can reference the moduleIds and names from this config endpoint which contains all of them - it is pretty printed below as well), adds a check for TTD and adds the domain if so
  • Utils - update the cookie sync manager's URL creation by adding an optional domain parameter

Screenshots/Video

Pretty printed config:
image

image

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

  • {Any additional information or context relevant to this PR}

Reference Issue (For employees only. Ignore if you are an outside contributor)

@rmi22186 rmi22186 requested a review from jaissica12 November 14, 2025 04:04
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
48.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@jaissica12 jaissica12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding the screenshot of the potential cookie sync partner, it was helpful for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants