feat: Add hashSha256 method for SHA-256 hashing #1116
+251
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
samdozor
requested changes
Nov 19, 2025
src/roktManager.ts
Outdated
| */ | ||
| public async hashSha256(attribute: string | number | boolean | undefined | null): Promise<string> { | ||
| if (attribute === undefined || attribute === null) { | ||
| throw new Error('Value cannot be null or undefined'); |
Contributor
There was a problem hiding this comment.
- i worry this will cause more harm than good in crashing the current loop/thread. our typical pattern would be to log an error or warning.
- I would also make the argument that there's nothing wrong with passing a null or undefined into this particular method. The method is able to act on the value passed in - it should just respond with the attribute (which is either null or undefined).
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback about logging pattern. Updated the code:
- For
null/undefinedinputs: Returns the value as-is with a logger.warning - For hash failures: Returns undefined with a logger.error
rmi22186
reviewed
Nov 21, 2025
| } | ||
|
|
||
| /** | ||
| * Hashes an attribute using SHA-256 |
Member
There was a problem hiding this comment.
One of the acceptance criteria is to embed the wSDK hashAttributes on line 255 for advertisers since they don't have the Rokt kit.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
hashSha256method and related helpers to provide SHA-256 hashing functionality for advertisers using the mParticle Web SDK without requiring the Rokt Kit dependency.What Has Changed
hashSha256methodScreenshots/Video
Checklist
Additional Notes
Reference Issue (For employees only. Ignore if you are an outside contributor)