Skip to content

fix: do not reach into duckdb_engine internals #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
machow wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: do not reach into duckdb_engine internals #485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion siuba/sql/verbs/compute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def _collect(__data, as_df = True):
# see https://github.com/pandas-dev/pandas/issues/45678
# going to handle here for now. address once LazyTbl gets
# subclassed per backend.
duckdb_con = conn.connection.c
duckdb_con = conn.connection
return duckdb_con.query(str(compiled)).to_df()
else:
#
Expand Down
Loading