Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage.yml and main.yml: silence actionlint warnings #341

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cooljeanius
Copy link

Without this PR, actionlint prints the following warnings on this repo's GitHub Actions workflows:

$ actionlint
.github/workflows/coverage.yml:33:9: shellcheck reported issue in this script: SC2046:warning:2:8: Quote this to prevent word splitting [shellcheck]
   |
33 |         run: |
   |         ^~~~
.github/workflows/coverage.yml:45:9: shellcheck reported issue in this script: SC2086:info:5:119: Double quote to prevent globbing and word splitting [shellcheck]
   |
45 |         run: |
   |         ^~~~
.github/workflows/coverage.yml:45:9: shellcheck reported issue in this script: SC2086:info:6:84: Double quote to prevent globbing and word splitting [shellcheck]
   |
45 |         run: |
   |         ^~~~
.github/workflows/main.yml:28:9: shellcheck reported issue in this script: SC2006:style:1:7: Use $(...) notation instead of legacy backticks `...` [shellcheck]
   |
28 |         run: |
   |         ^~~~
.github/workflows/main.yml:46:9: shellcheck reported issue in this script: SC2046:warning:4:18: Quote this to prevent word splitting [shellcheck]
   |
46 |         run: |
   |         ^~~~
.github/workflows/main.yml:46:9: shellcheck reported issue in this script: SC2046:warning:6:17: Quote this to prevent word splitting [shellcheck]
   |
46 |         run: |
   |         ^~~~

This PR silences them.

mostly from shellcheck about variable quoting
@cooljeanius
Copy link
Author

Would it make sense for me to handle yamllint warnings in this PR, too, or should I open a separate PR for that?

- name: Install MacPorts Base
run: |
set -eu
sudo make install
- name: Test MacPorts Base
run: |
set -eu
LLVM_PROFILE_FILE="$PWD/cov-%p.profraw" make test
LLVM_PROFILE_FILE="${PWD}/cov-%p.profraw" make test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to add braces here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it helps me grok more easily where exactly the variable begins and ends

.github/workflows/coverage.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/coverage.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
...instead of silencing them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants