refactor(soup): refactor soup and unified list implementation #1248
+5,567
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on filter or sort change
…t and replace query with generic source. Add EntityRow stuff
synoet
reviewed
Jan 30, 2026
| page_size?: number; | ||
| } | ||
|
|
||
| interface EntitiesQueryRequesdtBody { |
Comment on lines
61
to
63
| // ============================================================================ | ||
| // Entity Type Filters | ||
| // ============================================================================ |
Comment on lines
+53
to
+68
|
|
||
| export const SoupViewContext = createContext<SoupViewContextValues>(); | ||
|
|
||
| export const useSoupView = () => { | ||
| const context = useContext(SoupViewContext); | ||
|
|
||
| if (!context) { | ||
| throw new Error( | ||
| 'useSoupView can only be used under a SoupViewContext.Provider' | ||
| ); | ||
| } | ||
|
|
||
| return context; | ||
| }; | ||
|
|
||
| export const useMaybeSoupView = () => useContext(SoupViewContext); |
Contributor
There was a problem hiding this comment.
maybe just use the createContextProvider from solid primitives ? or the asserted one ?
| if (types.length === 0) types = []; | ||
| const includeArray: UnifiedSearchIndex[] = []; | ||
| for (const type of types) { | ||
| switch (type) { |
Contributor
There was a problem hiding this comment.
nit: uise ts-pattern's match
Comment on lines
+81
to
+93
| // ============================================================================ | ||
| // Lazy Initialization (avoids creating signals at module load time) | ||
| // ============================================================================ | ||
|
|
||
| let _priorityLabelToggles: SignalToggle<string>[] | null = null; | ||
| let _priorityMetadataToggles: SignalToggle<EmailMetadataKey>[] | null = null; | ||
| let _depriorityLabelToggles: SignalToggle<string>[] | null = null; | ||
| let _depriorityMetadataToggles: SignalToggle<EmailMetadataKey>[] | null = null; | ||
|
|
||
| let _priorityLabels: Accessor<Set<string>> | null = null; | ||
| let _depriorityLabels: Accessor<Set<string>> | null = null; | ||
| let _priorityMetadata: Accessor<Set<EmailMetadataKey>> | null = null; | ||
| let _depriorityMetadata: Accessor<Set<EmailMetadataKey>> | null = null; |
Contributor
There was a problem hiding this comment.
This seems completely unnecessary.
| readonly id: string; | ||
| readonly label: string; | ||
| readonly filterIds: readonly string[]; | ||
| readonly allowMultiple?: boolean; |
Contributor
There was a problem hiding this comment.
I don't think allowMultiple is used. Would be nice to configure groups to not be mutually exclusive if we wanted to.
| label: 'Mail', | ||
| predicate: emailFilter, | ||
| group: 'type', | ||
| shortcut: 'l', |
Contributor
There was a problem hiding this comment.
Do we need the shortcuts here? Can't we let the hotkey logic handle deciding what filter gets bound to what key ?
…-unified-list-and-soup-implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.