fail to send logging #1255
Merged
fail to send logging #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
whutchinson98
requested changes
Jan 30, 2026
|
|
||
| if extraction_status != ExtractionStatusEnum::Incomplete { | ||
| ws_send( | ||
| if let Err(err) = ws_send( |
Member
There was a problem hiding this comment.
.inspect_err is cleaner here imo.
| // We have been polling this attachment for too long, so we should stop | ||
| // polling it. | ||
| ws_send( | ||
| if let Err(err) = ws_send( |
| if let Err(e) = sender.send(message) { | ||
| tracing::error!(error=%e, "failed to send message to channel"); | ||
| } | ||
| pub fn ws_send( |
Member
There was a problem hiding this comment.
If you do tracing::instrument here you could have it automatically log errors for you so you don't need to map error each time
| .await; | ||
| if let Err(err) = result { | ||
| ws_send( | ||
| if let Err(err) = result |
| Ok(access) => match access { | ||
| AccessLevel::View | AccessLevel::Comment => { | ||
| ws_send( | ||
| if let Err(send_err) = ws_send( |
| Ok(access) => match access { | ||
| AccessLevel::View | AccessLevel::Comment => { | ||
| ws_send( | ||
| if let Err(send_err) = ws_send( |
| { | ||
| Err(e) => { | ||
| ws_send(&message_sender_clone, FromWebSocketMessage::Error(e)); | ||
| if let Err(send_err) = |
| Ok(id) => Arc::new(id), | ||
| Err(_) => { | ||
| ws_send( | ||
| if let Err(send_err) = ws_send( |
| )), | ||
| ), | ||
| }; | ||
| if let Err(send_err) = send_result { |
| ensure_user_attachment_access(&ctx, user_context.clone(), attachments).await | ||
| { | ||
| ws_send(&message_sender_clone, FromWebSocketMessage::Error(err)); | ||
| if let Err(send_err) = |
whutchinson98
approved these changes
Jan 30, 2026
Address PR feedback: - Add #[tracing::instrument(skip(sender), err)] to ws_send - Replace if let Err patterns with .ok() since errors now auto-logged - Remove redundant manual error logging at ws_send call sites Co-Authored-By: Claude Opus 4.5 <[email protected]>
ehayes2000
force-pushed
the
ws-disconnect
branch
from
8fab42e to
21e34ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.