Skip to content

Conversation

@filippopecci
Copy link
Collaborator

Description

This PR corrects bug that was not passing discharge and inflow efficiencies to HydroRes asset.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g., docstrings for new functions, updated/new .md files in the docs folder)
  • My changes generate no new warnings
  • I have tested the code to ensure it works as expected
  • New and existing unit tests pass locally with my changes:
julia> using Pkg
julia> Pkg.test("MacroEnergy")

Copy link
Collaborator

@RuaridhMacd RuaridhMacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Filippo. This correction looks good to me.

@RuaridhMacd RuaridhMacd merged commit 7b34bb9 into macroenergy:main Oct 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants