CMake PIC Option #1041
Closed
CMake PIC Option #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why don't you just do cmake <PATH_TO_SOURCE> -DCMAKE_POSITION_INDEPENDENT_CODE=ON |
My initial testing was incorrect, I have deleted my other comments. Your solution works for submodules. |
|
So if it works, why 4 additional lines to get it working? |
I agree, that's why my PR is closed. My initial concern was about building zlib from a submodule, but I tested your solution and it works fine for that. Thanks for reviewing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For static build, new option
ZLIB_BUILD_PICwould enable position independent code for the static library. I have set it toOFFas a default. I noticed there was an issue filed #21, which was again mentioned in #831.