Conversation
Test Results166 tests 165 ✅ 7s ⏱️ Results for commit 3d782e2. ♻️ This comment has been updated with latest results. |
|
le2sky
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR 요약
1. 문제점 (AS-IS)
SubscribeService의 구독 트랜잭션 내에서@Async를 통해 메일 발송을 직접 호출하고 있었습니다.MailSender)에 직접 의존하여 단일 책임 원칙을 위배하고 있었습니다.2. 개선 방안 (TO-BE)
ApplicationEventPublisher를 통해SubscribeCreatedEvent를 발행하도록 변경했습니다.@TransactionalEventListener(phase = TransactionPhase.AFTER_COMMIT)을 적용했습니다.3. 기대 효과