Traverse upwards to find ./magefiles directory #513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up from the other PR that has stalled. (#290)
I am using mage in a monorepo, with many layers of folders that may contain magefiles. It's been a major improvement working with this repo when mage walks up the tree to find the closest magefiles folder.
This PR causes the following affects:
magefilesfolder within the current directory.gitfolder is detected, it stops. This is based on the assumption that many magefiles probably should be scope to their git repositoryMAGEFILE_NO_TRAVERSEas an environment variableI can see an argument for some sort of
.magebuildor.magerootfile that also can be used to indicate traversal stopping.I did not update the website. I'm open to that, however wanted to get some opinions on this before I work on it much further.
Thanks!