Fix message localisation #3428
Open
Fix message localisation #3428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@magento run all tests |
engcom-Hotel
approved these changes
Jul 24, 2025
|
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests |
|
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests |
✔️ QA PassedNo manual testing required for the changes. This PR improves the code and also removed sprintf() usage from the phrase. sprintf() inside phrase can cause the localization issue. we use %1, %2, etc. inside __() for placeholders. This ensures proper translation and localization support. The failed integration test is known issue & not related to this PR: https://jira.corp.adobe.com/browse/AC-15195 The remaining build is green hence moving this PR in Merge In Progress. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Fix the phrase to be localized. The sprintf function prevent the phrase to be translatable because the token change every time a variable is interpolated.
Questions or comments
Related work on main repo: magento/magento2#40033
Contribution checklist (*)