Include all Magento2 sniffs in Magento2Framework #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihor-sviziev
approved these changes
Jul 14, 2022
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
6 tasks
|
@magento import PR to magento-commerce/magento-coding-standard repository |
|
@sinhaparul the Pull Request is successfully imported. |
|
@magento import PR to magento-commerce/magento-coding-standard repository |
|
@sidolov the Pull Request is successfully imported. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have recently opened a pull request on https://github.com/magento/magento2. When I ran the static analysis automated test, some complaints were raised (for unchanged parts of the files which were being fixed/modified). To see these locally, I ran
phpcs --standard=Magento2Framework path-to/file.php, however not all the complaints showed. When I ranphpcs --standard=Magento2 path-to/file.phpthe other complaints were visible. It doesn't seem right that theMagento2Frameworkstandard doesn't include the rules defined in theMagento2standard. This pull request fixes this inconsistency.