add condition to product options#892
Closed
dhruvi-prajapat1 wants to merge 2 commits into
Closed
Conversation
Author
|
@magento run all tests |
Collaborator
|
@magento run all tests |
engcom-Hotel
requested changes
Apr 4, 2025
engcom-Hotel
left a comment
Collaborator
There was a problem hiding this comment.
Hello @dhruvi-prajapat1,
Thanks for the contribution!
Please add an automated test in accordance to the DOD.
Thanks
Collaborator
|
Hello @dhruvi-prajapat1, Gentle reminder to add an automated test and also please fix the failed static tests. Thanks |
Collaborator
|
Hello @dhruvi-prajapat1, We appreciate your contribution! Since we haven't received a response from you for an extended period, we are closing this PR for now. Whenever you're ready to resume work on this, please feel free to reopen it or request us to do so. We'll be more than happy to assist you. Thanks once again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preconditions (*)
Description (*)
When adding a Product Slider through Page Builder and selecting the Product Carousel appearance, an error occurs:
“Error filtering template: Warning: Undefined array key "options" in /var/www/public_html/vendor/magento/module-page-builder/view/frontend/templates/catalog/product/widget/content/carousel.phtml on line 64”
Related Issue(*)
Fixes #891
Manual testing scenarious(*)
Expected result (*)
The Product Slider should appear correctly after saving Edit Products.
Actual result (*)
After saving Edit Products an error message is displayed instead of the Product Slider.
Additional Information(*)
As I checked in file magento/module-page-builder /view/frontend/templates/catalog/product/widget/content/carousel.phtml The issue occurs when the product slider does not have a bundle product. At that time, the options are not defined, causing an error.
Checklist