Add missing id attribute to the Reader.php #895
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a missing ID attribute to the pagebuilder's config content type reader.
Description (*)
You can see that the commit only adds a single line of code. The reason we need this line is to allow developers to extend the additional_data/item[name="uploaderConfig"] key in the view/adminhtml/pagebuilder/content_type/*.xml files. I'm not sure whether the absence of this key was intentional or not, but without this fix, attempting to extend these XML files in a custom module will result in an exception. Personally, I tried to extend image.xml, banner.xml, and slide.xml to add webp and avif to the allowedExtensions.
Story
Bug
Task
Fixed Issues (if relevant)
Builds
Related Pull Requests
Manual testing scenarios (*)
Questions or comments
Checklist