Skip to content

Add missing id attribute to the Reader.php #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

FY0u11
Copy link

@FY0u11 FY0u11 commented Apr 25, 2025

Add a missing ID attribute to the pagebuilder's config content type reader.

Description (*)

You can see that the commit only adds a single line of code. The reason we need this line is to allow developers to extend the additional_data/item[name="uploaderConfig"] key in the view/adminhtml/pagebuilder/content_type/*.xml files. I'm not sure whether the absence of this key was intentional or not, but without this fix, attempting to extend these XML files in a custom module will result in an exception. Personally, I tried to extend image.xml, banner.xml, and slide.xml to add webp and avif to the allowedExtensions.

Story

Bug

Task

Fixed Issues (if relevant)

  1. magento/magento2-page-builder#<issue_number>: Issue title

Builds

Related Pull Requests

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant