Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/community-features#238: Don't trigger reload of ui listing at page load. #32090

Closed
wants to merge 4 commits into from
Closed

magento/community-features#238: Don't trigger reload of ui listing at page load. #32090

wants to merge 4 commits into from

Conversation

Den4ik
Copy link
Contributor

@Den4ik Den4ik commented Feb 10, 2021 •
edited by engcom-Foxtrot
Loading

Description (*)

This PR is a re-creation of #31919

Related Pull Requests

magento/adobe-stock-integration#1859

Fixed Issues (if relevant)

  1. Fixes Don't trigger reload of ui listing at page load community-features#238: Don't trigger reload of ui listing at page load.

Manual testing scenarios (*)

  1. See Don't trigger reload of ui listing at page load community-features#238: Don't trigger reload of ui listing at page load.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 10, 2021

Hi @Den4ik. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@engcom-Foxtrot engcom-Foxtrot mentioned this pull request Feb 10, 2021
Closed
4 tasks
@Den4ik
Copy link
Contributor Author

Den4ik commented Feb 10, 2021

@magento run all tests

@ihor-sviziev
Copy link
Contributor

@magento run Integration Tests

@Den4ik Den4ik changed the title magento/community-features#238: Don't trigger reload of ui listing at page load. WIP: magento/community-features#238: Don't trigger reload of ui listing at page load. Feb 11, 2021
ihor-sviziev
ihor-sviziev requested changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check the failing functional tests?

@ihor-sviziev ihor-sviziev added the Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. label Mar 5, 2021
@Den4ik
Copy link
Contributor Author

Den4ik commented Mar 5, 2021

Could you check the failing functional tests?

Hi, @ihor-sviziev I'm working on rework of this PR.

Den4ik added a commit to Den4ik/adobe-stock-integration that referenced this pull request Mar 16, 2021
@Den4ik
Fix class extends and unit tests related to PR magento/magento2/pull/…
e29a584 
…32090
Den4ik added a commit to Den4ik/adobe-stock-integration that referenced this pull request Mar 16, 2021
@Den4ik
[AdobeStockImageAdminUi] Fix class extends and unit tests related to PR
b798388 
magento/magento2/pull/32090
@Den4ik Den4ik mentioned this pull request Mar 16, 2021
Open
@Den4ik
Copy link
Contributor Author

Den4ik commented Mar 16, 2021

@magento run all tests

1 similar comment
@Den4ik
Copy link
Contributor Author

Den4ik commented Mar 16, 2021

@magento run all tests

@Den4ik
Copy link
Contributor Author

Den4ik commented Mar 17, 2021

@magento run all tests

@Den4ik
Copy link
Contributor Author

Den4ik commented Mar 23, 2021

@magento rull all tests

@Den4ik
Copy link
Contributor Author

Den4ik commented Mar 23, 2021

@magento run all tests

@Den4ik
Copy link
Contributor Author

Den4ik commented Mar 23, 2021

@magento run Unit Tests

@Den4ik
Copy link
Contributor Author

Den4ik commented Sep 12, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik
Copy link
Contributor Author

Den4ik commented Sep 13, 2022

@magento run Integration Tests, WebAPI Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@Den4ik Den4ik requested a review from edenduong September 13, 2022 12:12
@onlinebizsoft
Copy link

Really looking forward this

@Den4ik
Copy link
Contributor Author

Den4ik commented Mar 15, 2023

Really looking forward this

@onlinebizsoft you may vote PR with 👍

@onlinebizsoft onlinebizsoft mentioned this pull request Apr 9, 2023
Open
5 tasks
@Den4ik
Copy link
Contributor Author

Den4ik commented Nov 4, 2023

@magento run all tests

@magento-automated-testing Magento Automated Testing
Copy link

Pull Requests are not mergeable to the mainline. Please merge the latest mainlines to your Pull Requests and restart the builds.

@engcom-Delta engcom-Delta added the Project: Community Picked PRs upvoted by the community label Aug 16, 2024
@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Aug 19, 2024
@engcom-Hotel engcom-Hotel self-requested a review August 23, 2024 03:42
@engcom-Hotel
Copy link
Contributor

Hello @Den4ik,

Please resolve the conflicts in this PR. After that, we can pick this PR for further processing. Meanwhile, we are moving this PR On Hold.

Thanks

@Den4ik
Copy link
Contributor Author

Den4ik commented Aug 23, 2024

Hi @engcom-Hotel
Thanks for your message. I'll resolve conflict in next 2-3 days.

@lbajsarowicz
Copy link
Contributor

I think it's the same problem: #38734

@Den4ik
Copy link
Contributor Author

Den4ik commented Aug 30, 2024

In progress

@engcom-Hotel
Copy link
Contributor

Hello @Den4ik,

Have you got a chance to check the conflicts of this PR? Please fix them so that we can pick this PR for further processing.

Thanks

@Den4ik
Copy link
Contributor Author

Den4ik commented Sep 9, 2024

Hi @engcom-Hotel
Little bit busy but I hope to finish with update in a few days

@engcom-Hotel
Copy link
Contributor

engcom-Hotel commented Oct 9, 2024 •
edited
Loading

Hello @Den4ik,

This is a gentle reminder to resolve the conflicts on this PR so we can proceed with this.

Thanks

@engcom-Hotel
Copy link
Contributor

Hello @,

We appreciate your contribution!

Unfortunately, we haven't received a response from you for an extended period, so we are closing this PR for now.

Whenever you're ready to resume work on this, please feel free to reopen it or request us to do so. We'll be more than happy to assist you.

Thanks once again!

@alexgran
Copy link

Is there something we can assist here to get that done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev requested changes

@sidolov sidolov Awaiting requested review from sidolov

@sivaschenko sivaschenko Awaiting requested review from sivaschenko

@edenduong edenduong Awaiting requested review from edenduong

@engcom-Hotel engcom-Hotel Awaiting requested review from engcom-Hotel

Assignees
No one assigned
Labels
Area: Frontend Award: bug fix Award: category of expertise Award: complex Component: Customer Component: Ui Component: View help wanted Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Project: Community Picked PRs upvoted by the community Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't trigger reload of ui listing at page load