Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product layout based on attribute_set #36244

Merged
merged 12 commits into from
Feb 17, 2025
Merged

Product layout based on attribute_set #36244

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f048d0a
Update View.php
in-session Oct 5, 2022
d09a804
Update View.php
in-session Oct 5, 2022
0732463
Update View.php
in-session Oct 5, 2022
1dfd9ba
Merge branch '2.4-develop' into patch-21
in-session Oct 6, 2022
676f3be
Merge branch '2.4-develop' into patch-21
in-session Oct 13, 2022
75d55c3
Update View.php
in-session Oct 14, 2022
5b265e9
Merge branch '2.4-develop' into patch-21
engcom-Hotel May 31, 2024
dad1949
Merge branch '2.4-develop' into patch-21
engcom-November Jun 7, 2024
e77413a
Merge branch '2.4-develop' into patch-21
engcom-November Jun 10, 2024
31178d6
Merge branch '2.4-develop' into patch-21
engcom-Charlie Dec 20, 2024
55448c8
36244: fix static failure
engcom-Dash Dec 24, 2024
23a99e9
Merge branch '2.4-develop' into patch-21
engcom-Dash Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions app/code/Magento/Catalog/Helper/Product/View.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2011 Adobe
* All Rights Reserved.
*/

namespace Magento\Catalog\Helper\Product;
Expand Down Expand Up @@ -178,16 +178,19 @@ public function initProductLayout(ResultPage $resultPage, $product, $params = nu
if ($params && $params->getBeforeHandles()) {
foreach ($params->getBeforeHandles() as $handle) {
$resultPage->addPageLayoutHandles(['type' => $product->getTypeId()], $handle, false);
$resultPage->addPageLayoutHandles(['attribute_set' => $product->getAttributeSetId()], $handle, false);
$resultPage->addPageLayoutHandles(['id' => $product->getId(), 'sku' => $urlSafeSku], $handle);
}
}

$resultPage->addPageLayoutHandles(['type' => $product->getTypeId()], null, false);
$resultPage->addPageLayoutHandles(['attribute_set' => $product->getAttributeSetId()], null, false);
$resultPage->addPageLayoutHandles(['id' => $product->getId(), 'sku' => $urlSafeSku]);

if ($params && $params->getAfterHandles()) {
foreach ($params->getAfterHandles() as $handle) {
$resultPage->addPageLayoutHandles(['type' => $product->getTypeId()], $handle, false);
$resultPage->addPageLayoutHandles(['attribute_set' => $product->getAttributeSetId()], $handle, false);
$resultPage->addPageLayoutHandles(['id' => $product->getId(), 'sku' => $urlSafeSku], $handle);
}
}
Expand Down