Fix-Wrong name conversion on getCustomerRegisterUrlUrl() at AuthenticationPopup.php by Vasudev-22 · Pull Request #36794 · magento/magento2

Vasudev-22 · 2023-01-31T05:20:07Z

Description (*)

Wrong name conversion on getCustomerRegisterUrlUrl() at AuthenticationPopup.php
Changed this function to getCustomerRegisterUrl()

Related Pull Requests

#36735

Fixed Issues (if relevant)

Fixes Wrong name conversion on getCustomerRegisterUrlUrl() at AuthenticationPopup.php #36735

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2023-01-31T05:20:10Z

Hi @Vasudev-22. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

Vasudev-22 · 2023-01-31T05:24:56Z

@magento run all tests

magento-automated-testing · 2023-01-31T05:25:04Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik

@Vasudev-22 Thanks for your PR. Change of public method name is not allowed by Backward compatibility policy. You may add new one private method with correct name and mark original @deprecated

Vasudev-22 · 2023-02-08T01:58:33Z

Hi @Den4ik ,

@Vasudev-22 Thanks for your PR. Change of public method name is not allowed by Backward compatibility policy. You may add new one private method with correct name and mark original @deprecated

I was updated that in PR

Vasudev-22 · 2023-02-08T01:58:46Z

@magento run all unit tests

magento-automated-testing · 2023-02-08T01:58:51Z

Failed to run the builds. Please try to re-run them later.

Vasudev-22 · 2023-02-08T01:59:35Z

@magento run all tests

magento-automated-testing · 2023-02-08T01:59:40Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

hostep · 2023-02-09T15:26:42Z

     */
    public function getCustomerRegisterUrlUrl()
    {
        return $this->getUrl('customer/account/create');


I would call $this->getCustomerRegisterUrl(); here, to avoid code duplication.

@Vasudev-22: can you take a look at this remark above also? Thanks! 🙂

As for the deprecation notice, I would put the following, to indicate which method to use instead:

* @deprecated * @see getCustomerRegisterUrl

@hostep , Updated.
Thanks

Thanks 2 more remarks:

I would call return $this->getCustomerRegisterUrl(); here, instead of return $this->getUrl('customer/account/create'); to avoid code duplication.

Please replace @deprecated due to requirements just with @deprecated, I think you may have misunderstood @Den4ik's remark

Thank you!

@hostep Yes confused those comments, Now updated.
Thanks for pointing.

Den4ik · 2023-02-09T15:48:32Z

    /**
     * Get customer register url
-     *
+     * @deprecated


Please add deprecation comment due to requirements

@Den4ik , deprecation comment added.

Vasudev-22 · 2023-02-20T13:31:35Z

@magento run all tests

magento-automated-testing · 2023-02-20T13:31:44Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

hostep · 2023-02-20T16:25:13Z

+     * Get customer register url
+     * @return string
+     */
+    private function getCustomerRegisterUrl()


I think this one should be public instead of private, because the original method was also public?

Update: @Den4ik: I see you mentioned making it private in your earlier review. But won't we cause confusion with callers of the original method when we mark that one as deprecated and give no new method as alternative to call?

lbajsarowicz · 2026-08-30T11:08:47Z

@Vasudev-22 — every review point here was addressed except one, and it is still open: @hostep asked whether the replacement should be public rather than private, since the original getCustomerRegisterUrlUrl() was public and deprecating it without a callable public alternative leaves external callers with nowhere to go. I think hostep is right.

The typo is still on 2.4-develop (AuthenticationPopup.php:125, called at :77). If you would like to finish this yourself, say so. Otherwise I will take it over, make the new method public, and rebase — opening a separate PR from my fork crediting you.

lbajsarowicz · 2026-08-30T11:14:40Z

Opened #41168 which continues this PR — rebased onto current 2.4-develop with your commits and authorship preserved, and with @hostep's outstanding point addressed: the replacement method is now public, so callers of the deprecated getCustomerRegisterUrlUrl() have a BC-safe alternative to move to.

@Vasudev-22 thanks for the original fix. @hostep @Den4ik #41168 should be ready for review.

Magento name conversion fix for the function getCustomerRegisterUrlUrl()

73d00d8

m2-community-project Bot added the Priority: P3 May be fixed according to the position in the backlog. label Jan 31, 2023

m2-github-services added Partner: EY partners-contribution Pull Request is created by Magento Partner labels Jan 31, 2023

m2-community-project Bot added the Progress: pending review label Jan 31, 2023

Den4ik suggested changes Feb 7, 2023

View reviewed changes

m2-community-project Bot assigned Den4ik Feb 7, 2023

m2-community-project Bot added Progress: needs update and removed Progress: pending review labels Feb 7, 2023

Vasudev-22 and others added 2 commits February 8, 2023 07:26

Method name is updated

8b638e2

Merge branch '2.4-develop' into issue-36735

4ec6b63

Vasudev-22 requested a review from Den4ik February 8, 2023 01:58

hostep reviewed Feb 9, 2023

View reviewed changes

m2-community-project Bot assigned hostep Feb 9, 2023

m2-community-project Bot added Progress: review and removed Progress: needs update labels Feb 9, 2023

hostep removed their assignment Feb 9, 2023

Den4ik suggested changes Feb 9, 2023

View reviewed changes

m2-community-project Bot added Progress: needs update Progress: review and removed Progress: review Progress: needs update labels Feb 9, 2023

Vasudev-22 and others added 2 commits February 20, 2023 18:59

deprecation comment added

009a4c8

Merge branch '2.4-develop' into issue-36735

c3f710c

m2-community-project Bot assigned hostep Feb 20, 2023

hostep removed their assignment Feb 20, 2023

deprecation comment updated

b514f98

m2-community-project Bot assigned hostep Feb 20, 2023

hostep removed their assignment Feb 20, 2023

updated

d197a4f

Vasudev-22 requested review from Den4ik and hostep and removed request for Den4ik and hostep February 20, 2023 15:25

hostep reviewed Feb 20, 2023

View reviewed changes

m2-community-project Bot assigned hostep Feb 20, 2023

hostep removed their assignment Feb 20, 2023

Merge branch '2.4-develop' into issue-36735

65153f5

lbajsarowicz mentioned this pull request Aug 30, 2026

Add correctly named getCustomerRegisterUrl() and deprecate the typo (#36735) #41168

Open

4 tasks

Uh oh!

Conversation

Vasudev-22 commented Jan 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant Bot commented Jan 31, 2023

Uh oh!

Vasudev-22 commented Jan 31, 2023

Uh oh!

magento-automated-testing Bot commented Jan 31, 2023

Uh oh!

Den4ik left a comment

Choose a reason for hiding this comment

Uh oh!

Vasudev-22 commented Feb 8, 2023

Uh oh!

Vasudev-22 commented Feb 8, 2023

Uh oh!

magento-automated-testing Bot commented Feb 8, 2023

Uh oh!

Vasudev-22 commented Feb 8, 2023

Uh oh!

magento-automated-testing Bot commented Feb 8, 2023

Uh oh!

hostep Feb 9, 2023

Choose a reason for hiding this comment

Uh oh!

hostep Feb 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Vasudev-22 Feb 20, 2023

Choose a reason for hiding this comment

Uh oh!

hostep Feb 20, 2023

Choose a reason for hiding this comment

Uh oh!

Vasudev-22 Feb 20, 2023

Choose a reason for hiding this comment

Uh oh!

Den4ik Feb 9, 2023

Choose a reason for hiding this comment

Uh oh!

Vasudev-22 Feb 20, 2023

Choose a reason for hiding this comment

Uh oh!

Vasudev-22 commented Feb 20, 2023

Uh oh!

magento-automated-testing Bot commented Feb 20, 2023

Uh oh!

hostep Feb 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lbajsarowicz commented Aug 30, 2026

Uh oh!

lbajsarowicz commented Aug 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Vasudev-22 commented Jan 31, 2023 •

edited

Loading

hostep Feb 20, 2023 •

edited

Loading

hostep Feb 20, 2023 •

edited

Loading