Fix issue where upsell and related products were controlling each oth…

[igorwulff]

…ers visibility

On a PDP with both upsell and related products with a limit set and a shared set of some of the products an issue could arise where products being hidden or shown by the related product js would impact the upsell products and vice versa.

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @igorwulff. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Hotel]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

[engcom-Hotel]

Hello @igorwulff,

Thanks for the contribution!

I suggest you to cover the changes with some automated tests like functional tests.

Thanks

[engcom-Dash]

@magento run all tests

[lbajsarowicz]

@igorwulff — this is still an unfixed bug on current 2.4-develop (the global li#product-item_<id>{display:none} rule and the duplicate DOM ids are both still in items.phtml at lines 203/207), and the only thing ever asked of you was the automated test @engcom-Hotel requested.

If you would like to finish it yourself, say so and I will leave it alone. Otherwise I will take it over: rebase onto current 2.4-develop, keep the diff to the id-namespacing, and add the functional test. I will open a separate PR from my fork crediting you and Youwe so your authorship here stays intact.

[lbajsarowicz]

Opened #41171 which continues this PR — rebased onto current 2.4-develop with your commit and authorship preserved, plus the functional test @engcom-Hotel asked for.

@igorwulff for the record I dropped the second commit (the copyright-header rewrite and $block->escape* → $escaper->escape* rename) during the rebase — it conflicted with changes upstream has made since and was not part of the fix, so the new PR is limited to the id namespacing.

[lbajsarowicz]

Correction to my earlier comment, @igorwulff — I was wrong to describe your second commit as purely cosmetic. @engcom-Dash's "Fix failed static tests" was doing real work: the Magento2 sniff warns on every $block->escape* call in a touched template, and the upstream Static Tests build fails on warnings, so that conversion was required rather than stylistic. I have restored it in #41171.