-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Update wikimedia/less.php compiler #38191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Update the dependency to use newer 4.x version, this update fixes a php8.1 warning and includes multiple perfomance improvements on compilation, for exact changes from current 3.2.1 -> 4.1.1 version see https://github.com/wikimedia/less.php/blob/master/CHANGES.md
Hi @brosenberger. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
@magento create issue |
php version still go up fast but this package seem falling behind when version less compatible still 2.5.3. I don't see any update or road map to newer version . For example 4.2.0 lessjs -> 4.2.0 |
Description (*)
Update the dependency to use newer 4.x version, this update fixes a php8.1 warning and includes multiple perfomance improvements on compilation, for exact changes from current 3.2.1 -> 4.1.1 version see https://github.com/wikimedia/less.php/blob/master/CHANGES.md
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Resolved issues: