Skip to content

Update wikimedia/less.php compiler #38191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from

Conversation

brosenberger
Copy link
Contributor

@brosenberger brosenberger commented Nov 16, 2023

Description (*)

Update the dependency to use newer 4.x version, this update fixes a php8.1 warning and includes multiple perfomance improvements on compilation, for exact changes from current 3.2.1 -> 4.1.1 version see https://github.com/wikimedia/less.php/blob/master/CHANGES.md

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Update wikimedia/less.php compiler #38194: Update wikimedia/less.php compiler

Update the dependency to use newer 4.x version, this update fixes a php8.1 warning and includes multiple perfomance improvements on compilation, for exact changes from current 3.2.1 -> 4.1.1 version see https://github.com/wikimedia/less.php/blob/master/CHANGES.md
Copy link

m2-assistant bot commented Nov 16, 2023

Hi @brosenberger. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@brosenberger
Copy link
Contributor Author

@magento run all tests

Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Hotel
Copy link
Contributor

@magento create issue

@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Nov 16, 2023
@hostep
Copy link
Contributor

hostep commented Nov 18, 2023

There is more work involved with this, see my attempt over here: #37842 (and some explanation in #37841)

But I currently don't have time to proceed with this in the short term, I'll probably find more time in the year 2024, but feel free to take over my calc fixes... :)

@mrtuvn
Copy link
Contributor

mrtuvn commented Dec 6, 2023

php version still go up fast but this package seem falling behind when version less compatible still 2.5.3. I don't see any update or road map to newer version . For example 4.2.0
https://github.com/wikimedia/less.php/blob/a486d78b9bd16b72f237fc6093aa56d69ce8bd13/lib/Less/Version.php#L12

lessjs -> 4.2.0
https://cdn.jsdelivr.net/npm/less

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P3 May be fixed according to the position in the backlog. Progress: pending review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Update wikimedia/less.php compiler
4 participants