Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[*] Rework session destroy into customer session clean #39128

Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

sfritzsche
Copy link

Description (*)

Before:

The current session (incl. cart items) making a password “forget” request is destroyed as soon as a password request with a formally correct email address is received.

After:

The process is only triggered if the email address really exists.
If it does, only the customer session associated with the email address is reset and not the session that “requested” it.

Fixed Issues

  1. Fixes The shopping cart will be emptied as soon as the forgot password process has been started #39021

Manual testing scenarios (*)

  1. add a product to the shopping cart.
  2. start the "Forgot password" process on the "/customer/account/forgotpassword" page with a formally correct email address.
  3. the product is still in the shopping cart.

Copy link

m2-assistant bot commented Aug 30, 2024

Hi @sfritzsche. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Aug 30, 2024
@sfritzsche
Copy link
Author

@magento run all tests

@sfritzsche
Copy link
Author

@magento run all tests

@sfritzsche
Copy link
Author

@magento run all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The shopping cart will be emptied as soon as the forgot password process has been started
1 participant