Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-working regenerate flag #39140

Open
wants to merge 5 commits into
base: 2.4-develop
Choose a base branch
from
Open

Fix non-working regenerate flag #39140

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6c8f11f
Update GeneratedFiles.php
jissereitsma Sep 4, 2024
481edc4
Merge branch '2.4-develop' into patch-3
jissereitsma Sep 11, 2024
31aa73c
Merge branch '2.4-develop' into patch-3
engcom-Hotel Sep 13, 2024
7e6116c
39140: Declare visibility for class constants
engcom-Dash Sep 13, 2024
55cd626
Merge branch '2.4-develop' into patch-3
engcom-Dash Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/internal/Magento/Framework/Code/GeneratedFiles.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,17 @@ class GeneratedFiles
/**
* Regenerate flag file name
*/
const REGENERATE_FLAG = '/var/.regenerate';
public const REGENERATE_FLAG = 'var/.regenerate';

/**
* Regenerate lock file name
*/
const REGENERATE_LOCK = self::REGENERATE_FLAG . '.lock';
public const REGENERATE_LOCK = self::REGENERATE_FLAG . '.lock';

/**
* Acquire regenerate lock timeout
*/
const REGENERATE_LOCK_TIMEOUT = 5;
public const REGENERATE_LOCK_TIMEOUT = 5;

/**
* @var DirectoryList
Expand Down