Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.5] Add support for missing Curl methods to the Curl client #39469

Open
wants to merge 3 commits into
base: 2.5-develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
SOP-348 #36336 Fix invalid DELETE method reference (no payload)
lbajsarowicz committed Jan 16, 2025

Verified

This commit was signed with the committer’s verified signature.
lbajsarowicz Lukasz Bajsarowicz
commit 08bec19ee36e71e74961e3c60d21a5fe729a67db
4 changes: 1 addition & 3 deletions lib/internal/Magento/Framework/HTTP/Client/Curl.php
Original file line number Diff line number Diff line change
@@ -22,7 +22,6 @@ class Curl implements \Magento\Framework\HTTP\ClientInterface
'POST',
'PUT',
'PATCH',
'DELETE',
'OPTIONS'
];

@@ -276,14 +275,13 @@ public function put(string $uri, string|array $params): void
* Make DELETE request
*
* @param string $uri
* @param array|string $params
* @return void
*
* @url https://www.rfc-editor.org/rfc/rfc9110.html#section-9.3.5
*/
public function delete(string $uri, array|string $params = []): void
{
$this->makeRequest("DELETE", $uri, $params);
$this->makeRequest("DELETE", $uri);
}

/**