fix(catalog): align getChildren() method signature with caller and Flat implementation#40506
Open
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Open
Conversation
…at implementation Add $isActive and $sortByPosition parameters to ResourceModel\Category::getChildren() to match: - The Category model's call which passes 4 arguments - The ResourceModel\Category\Flat::getChildren() signature Previously, the model passed 4 arguments but the resource model only accepted 2, causing the extra arguments to be silently ignored. This created inconsistent behavior between flat and non-flat catalog modes and caused confusion for plugin developers. The default values maintain backward compatibility: - $isActive = true (same as previous implicit behavior) - $sortByPosition = false (no change in default behavior) Fixes magento#40257
|
Hi @lbajsarowicz. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Contributor
Author
|
@magento run all tests |
Contributor
Author
|
@magento run Functional Tests B2B, Functional Tests EE, Functional Tests CE
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description (*)
Align
ResourceModel\Category::getChildren()method signature with:ResourceModel\Category\Flat::getChildren()signatureProblem: The Category model calls
$this->getResource()->getChildren($this, $recursive, $isActive, $sortByPosition)but the resource model only accepted 2 parameters. This caused extra arguments to be silently ignored and inconsistent behavior between flat and non-flat catalog modes.Solution: Add
$isActiveand$sortByPositionparameters to match the Flat implementation. Default values maintain full backward compatibility.Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
⭐ Support my work
Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.
Learn more at https://github.com/sponsors/lbajsarowicz