Skip to content

feat: add CommitFinalize #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
snawaz wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add CommitFinalize #131

snawaz wants to merge 1 commit into from

Conversation

@snawaz
Copy link
Contributor

@snawaz snawaz commented Jan 5, 2026 •
edited
Loading

Coming soon..

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 5, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch snawaz/commit-finalize

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@snawaz Graphite App
Copy link
Contributor Author

snawaz commented Jan 5, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@snawaz snawaz mentioned this pull request Jan 5, 2026
Merged
@snawaz snawaz force-pushed the snawaz/size-class branch from 02c7ed0 to 293a606 Compare January 5, 2026 07:57
@snawaz snawaz force-pushed the snawaz/commit-finalize branch from d579de1 to f795dc8 Compare January 5, 2026 07:57
@snawaz snawaz changed the base branch from snawaz/size-class to graphite-base/131 January 5, 2026 09:29
@snawaz snawaz force-pushed the graphite-base/131 branch from 293a606 to 1874b4f Compare January 14, 2026 13:11
@snawaz snawaz force-pushed the snawaz/commit-finalize branch from f795dc8 to fa1cc24 Compare January 14, 2026 13:11
@snawaz snawaz changed the base branch from graphite-base/131 to main January 14, 2026 13:11
@snawaz snawaz force-pushed the snawaz/commit-finalize branch from fa1cc24 to b2d1983 Compare January 19, 2026 19:54
@snawaz snawaz mentioned this pull request Jan 19, 2026
Draft
GabrielePicco
GabrielePicco reviewed Jan 20, 2026
View reviewed changes
src/processor/fast/commit_finalize_internal.rs
"delegated account",
)?;
require_signer(args.validator, "validator account")?;
require_initialized_delegation_record(
Copy link
Contributor

@GabrielePicco GabrielePicco Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we pass the bumps for all PDAs we need to check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GabrielePicco GabrielePicco GabrielePicco left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@snawaz @GabrielePicco