forge--update-pullreq: Fetch and store review comments

[braineo]

Fetch and store review comments alongside with normal comments.

Before this change, the review comments are not visible in pullreq view like following

[braineo]

To demonstrate the idea I'll create normal comments vs review comments in the PR. This should be a normal comment that is display in the pullreq view

[braineo]

@tarsius, actually do you think this pr is related to #58?

[tarsius]

Yes, and also #266 (comment).

I plan to implement support for "review comments" next year. (More so than the post I just linked to suggests.) However, this year I am focusing on paying off the technical dept, which is (among other things) the result of merging/implementing too many minimal viable implementations of often requested features, as opposed to adding more technical dept by adding incomplete support for additional functionality.

So I have to decline this implementation as well.

Later in the above thread two packages are mentioned, which already implement such functionality on top of Forge. Please give those a try instead. (But notice that at least one of them is no longer maintained properly, so you might have to address some bit rot yourself, and maybe even offer to become the maintainer. If I remember correctly, Doom Emacs' fork currently is the best maintained version. You should start with that.)

I do not intend to add support for "review comments", that does not match the feature set provided by these packages.

[tarsius]

Some advice can be found in #472 (which may or may not still work).

[braineo]

Yes, and also #266 (comment).

I plan to implement support for "review comments" next year.
...
I do not intend to add support for "review comments", that does not match the feature set provided by these packages.

Thanks for the advice!

I did not quite understand whether you are or not going to add the support. If you are, I'm Looking forward to it. :)

Originally I wanted to implement "reply to" and "resolve" comment features. But later I found the review comments are not displayed so I made this quick change first.

I agree that the full support is not trivial since the review comments have conversation threads so that the comments are parented and not a flat list anymore. It should require the table to store such information but I did not spend time on that.