Add gitHub testing workflow and update sharp#152
Closed
rejas wants to merge 3 commits intomahnunchik:masterfrom
Closed
Add gitHub testing workflow and update sharp#152rejas wants to merge 3 commits intomahnunchik:masterfrom
rejas wants to merge 3 commits intomahnunchik:masterfrom
Conversation
|
Bumping sharp version is not enough for this library to work fine: #151 (review) |
Contributor
Author
|
Closing since this seems to be abandoned and I dont use the library anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a github workflow so the tests can be run without travis under different node and OS versions.
Since the tests would fail under macos and node 16 I also updated the sharp dependency, therefor fixing #149, #150 and #151