appstore: Fix/invalid auth code #394
Open
+52
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves error handling for App Store login, specifically around two-factor authentication (2FA) codes. It introduces a new error for invalid or expired 2FA codes, enhances the logic for parsing login responses, and adds comprehensive test coverage for these scenarios.
Error handling improvements:
ErrInvalidAuthCode
to represent invalid or expired 2FA codes inappstore_login.go
.ErrInvalidAuthCode
for various failure types and customer messages related to invalid 2FA codes.FailureTypeInvalidAuthCode
constant ("5005"
) to identify invalid auth code errors from the API.Test coverage enhancements:
fixing #392 and #387
need to reference @pradeepvizz for suggesting one request a 2FA code on the website and then utilizing that through the
auth-code
parameter.