Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ORT-2] feat: add KakaoLoginButton #2

Merged
merged 10 commits into from
Aug 30, 2024
3 changes: 2 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@
"editor.codeActionsOnSave": {
"source.fixAll.eslint": "explicit"
},
"git.pruneOnFetch": true
"git.pruneOnFetch": true,
"files.eol": "\n"
}
21 changes: 21 additions & 0 deletions app/components/KakaoLoginButton/KakaoLoginButton.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import React, { useMemo } from 'react';
import getUUID from '@/utils/getUUID';

const clientId = 'f5aa2f20e42d783654b8e8c01bfc6312';
//redirectUri는 등록된 redirectUri중에 임의로 사용했습니다.
const redirectUri = 'http://localhost:5173/oauth/kakao';
Comment on lines +4 to +6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우선은 상관없지만, 제가 Env 관련 작업을 하고 나면 환경변수로 변경하면 좋을 듯합니다!


const KakaoLoginButton: React.FC = () => {
const kakaoAuthUrl = useMemo(() => {
const userUUID = getUUID();
return `https://kauth.kakao.com/oauth/authorize?client_id=${clientId}&redirect_uri=${redirectUri}&response_type=code&state=${userUUID}`;
}, []);

return (
<a href={kakaoAuthUrl}>
<button>카카오로 로그인</button>
</a>
);
};

export default KakaoLoginButton;
3 changes: 3 additions & 0 deletions app/components/KakaoLoginButton/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import KakaoLoginButton from './KakaoLoginButton';

export default KakaoLoginButton;
6 changes: 4 additions & 2 deletions app/routes/_index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { MetaFunction } from '@remix-run/cloudflare';
import Test from '@/components/Test';
import KakaoLoginButton from '@/components/KakaoLoginButton';
// import Test from '@/components/Test';

export const meta: MetaFunction = () => [
{ title: 'ORT - 동아리 플랫폼' },
Expand All @@ -13,7 +14,8 @@ export const meta: MetaFunction = () => [
const Index = () => (
<div>
<h1>Ort</h1>
<Test />
{/* <Test /> */}
<KakaoLoginButton />
</div>
);

Expand Down
24 changes: 24 additions & 0 deletions app/routes/oauth.kakao.tsx.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import { LoaderFunction, json } from '@remix-run/cloudflare';
import axios, { AxiosError } from 'axios';

export const loader: LoaderFunction = async ({ request }) => {
const url = new URL(request.url);
const code = url.searchParams.get('code');
const state = url.searchParams.get('state');

try {
const response = await axios.post('(백엔드api url)', {
code,
state,
});
return json({ message: 'Success', data: response.data });
} catch (error) {
const axiosError = error as AxiosError;
console.error('Error sending code to backend:', axiosError);
return json({ message: 'Error', error: axiosError.message });
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 코드 부분 혹시 지워주실 수 있을까요? 제가 이어서 작업하겠습니다!

Copy link
Contributor Author

@crew852 crew852 Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지우면 커밋이 불가해서 대충 console.log 찍는 try문으로 대체해 놨습니다.
코드의 해당 부분 지우고 이어서 해주시면 될 것 같습니당~

  // 이 아래의 try문 지우고 이어서 하면 됩니다
  try {
    console.log(code, state);
  } catch {
    console.log(json);
  }
};

};

const KakaoRedirect = () => <div>카카오 로그인 중...</div>;

export default KakaoRedirect;
9 changes: 9 additions & 0 deletions app/utils/getUUID.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import { v4 as uuidv4 } from 'uuid';

//이용자의 uuid를 받아옵니다.
const getUUID = () => {
const getUserUUID = (): string => uuidv4();
return getUserUUID;
};

export default getUUID;
Copy link
Member

@aube-dev aube-dev Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한 파일에 하나의 함수만 넣는 방식인 것 같은데, 그러기엔 코드가 너무 짧아 보여서 그냥 app/utils/random.ts 정도로만 네이밍하고, default export가 아닌 named export를 하는 게 어떨까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그게 맞는 것 같긴 한데, 이 외에 이 함수와 같이 들어갈 만한 다른 함수가 생각나지 않아서 이렇게 작성했습니다.
그러나 말씀해주신 대로 이름 붙여 놓으면 나중에 뭔가 추가되어 수정을 하게 되어도 괜찮겠네요!
이것도 반영해 수정해 둘게요~

5 changes: 4 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@
"@remix-run/react": "2.10.2",
"@remix-run/serve": "2.10.2",
"@vanilla-extract/css": "1.15.3",
"axios": "^1.7.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 라이브러리 지워주실 수 있을까요? 제가 API 부분 작업하려고 합니다!

"isbot": "4.4.0",
"react": "18.3.1",
"react-dom": "18.3.1"
"react-dom": "18.3.1",
"uuid": "^10.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^을 붙이면 일관된 버전을 적용하지 않아서 예상치 못한 breaking change를 디버깅하기 어려울 수 있어요.

Suggested change
"uuid": "^10.0.0"
"uuid": "10.0.0"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오...이건 그냥 몰랐습니다
정말 위대합니다, 선생!

},
"devDependencies": {
"@commitlint/cli": "19.3.0",
Expand All @@ -39,6 +41,7 @@
"@storybook/test": "8.2.5",
"@types/react": "18.3.3",
"@types/react-dom": "18.3.0",
"@types/uuid": "^10.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@types/uuid": "^10.0.0",
"@types/uuid": "10.0.0",

"@typescript-eslint/eslint-plugin": "7.16.0",
"@typescript-eslint/parser": "7.16.0",
"@vanilla-extract/vite-plugin": "4.0.13",
Expand Down
76 changes: 76 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.